Re: Updated patches

Hi,

PFA updated patch for database node.

Issue fixed:
Separated some alter sql executions. As two or more sql can not execute as
single query.

--
*Harshal Dhumal*
*Software Engineer *

EenterpriseDB <http://www.enterprisedb.com>

On Thu, Feb 4, 2016 at 2:32 PM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:

> Hi,
>
> PFA updated patch for database node.
>
> Issue fixed:
> 1. Now database connects gracefully if focus is set on database node in
> tree.
> (Added selected callback function in database.js)
>
> 2. Fixed icon issue for node create/update dialog.
>
>
>
>
>
> --
> *Harshal Dhumal*
> *Software Engineer *
>
>
>
> EenterpriseDB <http://www.enterprisedb.com>
>
> On Thu, Feb 4, 2016 at 11:47 AM, Harshal Dhumal <
> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> PFA update patch for database node.
>>
>> Issues fixed:
>> Alter database with new tablespace fixed.
>>
>>
>>
>> --
>> *Harshal Dhumal*
>> *Software Engineer *
>>
>>
>>
>> EenterpriseDB <http://www.enterprisedb.com>
>>
>> On Wed, Feb 3, 2016 at 2:58 PM, Harshal Dhumal <
>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>
>>>
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Software Engineer *
>>>
>>>
>>>
>>> EenterpriseDB <http://www.enterprisedb.com>
>>>
>>> On Wed, Feb 3, 2016 at 2:47 PM, Harshal Dhumal <
>>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> PFA updated patch for database node.
>>>>
>>>> I have fixed almost all issues reported by Neel.
>>>>
>>>> --
>>>> *Harshal Dhumal*
>>>> *Software Engineer *
>>>>
>>>>
>>>>
>>>> EenterpriseDB <http://www.enterprisedb.com>
>>>>
>>>> On Tue, Feb 2, 2016 at 4:47 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com
>>>> > wrote:
>>>>
>>>>> Adding more comments.
>>>>>
>>>>> - "Delete Database" functionality is not working, we are getting below
>>>>> error.
>>>>> * The requested URL was not found on the server. If you entered
>>>>> the URL manually please check your spelling and try again.*
>>>>>
>>>>> *Done*
>>>
>>>> - "Drop/Delete functionality is not working, we are getting below
>>>>> error."
>>>>> {"success": 0, "data": null, "info": "", "result": null,
>>>>> "errormsg": "Connection to the server has been lost!"}
>>>>> To drop/delete the database, we need to first disconnect the database
>>>>> connection and Drop the database, If it is unsuccessful then we again need
>>>>> to
>>>>> make the connection to database.
>>>>>
>>>>> *Done*
>>>
>>>> - "Connection Limit" parameter value is not displayed properly. We set
>>>>> the value to "2" then also it shows the wrong value as "-1".
>>>>>
>>>> *Done*
>>>
>>>> - When we edit the variables parameters along with name change then
>>>>> query is not taking the new database name.
>>>>>
>>>>> *Done*
>>>
>>>> *Wrong SQL:- *
>>>>> ALTER DATABASE test_2 RENAME TO test_2_up;
>>>>> COMMENT ON DATABASE test_2_up
>>>>> IS 'updated comment....';
>>>>> ALTER DATABASE test_2 SET wal_compression TO 'off';
>>>>> ALTER ROLE role1 IN DATABASE test_2 SET zero_damaged_pages TO 'off';
>>>>>
>>>>> *Correct SQL:-*
>>>>> ALTER DATABASE test_2 RENAME TO test_2_up;
>>>>> COMMENT ON DATABASE test_2_up
>>>>> IS 'updated comment....';
>>>>> ALTER DATABASE *test_2_up* SET wal_compression TO 'off';
>>>>> ALTER ROLE role1 IN DATABASE *test_2_up* SET zero_damaged_pages TO
>>>>> 'off';
>>>>>
>>>>> *Done*
>>>
>>>> - Default Privileges are not getting displayed when we select any
>>>>> database node in Properties panel.
>>>>>
>>>> *We won't be showing default privileges in properties mode.*
>>>
>>>> - When the database is already disconnected and when user again perform
>>>>> "Disconnect database" then it gives python error in backend saying "
>>>>> *NameError: **name 'unauthorized' is not defined*".
>>>>>
>>>> *Done*
>>>
>>>> - When we update only database name then we are getting error saying "*name
>>>>> 'conn' is not defined*".
>>>>>
>>>>> *Done*
>>>
>>>> Thanks,
>>>>> Neel Patel
>>>>>
>>>>> On Tue, Feb 2, 2016 at 1:25 PM, Neel Patel <
>>>>> neel(dot)patel(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Harshal,
>>>>>>
>>>>>> Please find below review comments.
>>>>>>
>>>>>> - While applying the patch, we are getting warning regarding
>>>>>> "trailing whitespace.". Please remove the warning.
>>>>>>
>>>>> *Done*
>>>
>>>> - We are getting error saying "*IndexError: tuple index out of range*"
>>>>>> on python side while connecting to "template0" database.
>>>>>>
>>>>> *Done (Now user can not connect to template0)*
>>>
>>>> - Many properties are not getting displayed in "Properties" window when
>>>>>> we click on any database. Check for pgadmin3 to show all the properties.
>>>>>>
>>>>> e.g. Connected, System Database, Allow connections etc..
>>> *Partially done*
>>>
>>>> - Do proper formatting while displaying SQL statements in SQL tab.
>>>>>> Below statement semicolon should not be in next line.
>>>>>>
>>>>> *Done*
>>>
>>>
>>>> e.g.
>>>>>> CREATE DATABASE postgres
>>>>>> WITH OWNER = postgres
>>>>>> ENCODING = 'UTF8'
>>>>>> TABLESPACE = pg_default
>>>>>> ;
>>>>>>
>>>>> *Done*
>>>
>>>>
>>>>>>
>>>>> - While creating the new database, tablespace drop down values are not
>>>>>> filled correctly. Current it shows the "Template" field value which is
>>>>>> wrong.
>>>>>>
>>>>> *Done*
>>>
>>>> - By default, when user does not specify any "collation" and "character
>>>>>> type" then it should be set as "en_US.UTF8" and accordingly it should
>>>>>> display in
>>>>>> Properties and SQL window.
>>>>>>
>>>>> *Done*
>>>
>>>> - When we connect to database 9.1 then query is getting failed to
>>>>>> execute. Below are the error.
>>>>>>
>>>>> *Done*
>>>
>>>
>>>> *2016-02-02 11:46:59,597: ERROR pgadmin: Failed to execute query
>>>>>> (execute_dict) for the server #3- DB:test_db_1 (Query-id: 9678389):*
>>>>>> *Error Message:function expression in FROM cannot refer to other
>>>>>> relations of same query level*
>>>>>> *LINE 27: aclexplode(datacl) d*
>>>>>>
>>>>>> - When we edit any database and PG version is 9.1 then in default
>>>>>> privileges the "Types" tab should not allow to enter the value or it should
>>>>>> not be
>>>>>> displayed.
>>>>>>
>>>>> *TODO *
>>>
>>>> - We are not able to edit any database if PG version is 9.1 as we are
>>>>>> getting error due to query is getting failed.
>>>>>>
>>>>> *Done*
>>>
>>>> - We need to implement "Statistics" tab window implementation to show
>>>>>> the different properties.
>>>>>>
>>>>> *TODO*
>>>
>>>> - When we add new parameters in "Variables", it generates the wrong
>>>>>> SQL. In the below Query it should add the database name as well.
>>>>>>
>>>>>> Wrong SQL : -
>>>>>> ALTER ROLE role1 SET transaction_read_only TO 'on';
>>>>>> Correct SQL:-
>>>>>> ALTER ROLE role1 IN DATABASE test_db_3 SET
>>>>>> transaction_read_only = 'on';
>>>>>>
>>>>>> *Done*
>>>
>>>> - While editing the existing database, enter some of the values from
>>>>>> "Variables". Though we add the valid value, it shows error saying "Please
>>>>>> enter
>>>>>> some value". It should not display the message and allow user to
>>>>>> set the modified parameters.
>>>>>>
>>>>> *Done* *(bug in variable.js. Patch already submitted.)*
>>>
>>>> - When we click on any database, it shows the properties of the
>>>>>> selected node in "Properties" tab. In that window, all the database
>>>>>> properties should be
>>>>>> "Read only". We should not change the database properties from
>>>>>> "Properties" panel.
>>>>>>
>>>>> *Done* *(We won't be showing complex controls in properties mode as
>>> such controls are difficult to disable)*
>>>
>>>> - In "Security" tab, After adding new privilege, we are not able to add
>>>>>> the second privilege due to scroll bar issue.
>>>>>>
>>>>> *TODO (This is common issue for all dialogs.) *
>>>
>>>> - After clicking on "Add" button in security tab, "Save" button is
>>>>>> getting disabled so we are not able to save the modified parameters.
>>>>>>
>>>>>> *TODO **(This is common issue for all dialogs.) *
>>>
>>>> We are still reviewing the code and we will send more comments once the
>>>>>> review will be completed.
>>>>>>
>>>>>> Thanks,
>>>>>> Neel Patel
>>>>>>
>>>>>> On Fri, Jan 22, 2016 at 6:46 PM, Ashesh Vashi <
>>>>>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>>
>>>>>>> Hi Harshal,
>>>>>>>
>>>>>>> On Fri, Jan 22, 2016 at 2:48 PM, Harshal Dhumal <
>>>>>>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> PFA updated patches:
>>>>>>>>
>>>>>>>> I have made changes as per Ashesh's suggestions.
>>>>>>>>
>>>>>>> As discussed, I've committed the privileges, and variable changes.
>>>>>>>
>>>>>>> I will look into database patch later.
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> --
>>>>>>>
>>>>>>> Thanks & Regards,
>>>>>>>
>>>>>>> Ashesh Vashi
>>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>>>> <http://www.enterprisedb.com/>
>>>>>>>
>>>>>>>
>>>>>>> *http://www.linkedin.com/in/asheshvashi*
>>>>>>> <http://www.linkedin.com/in/asheshvashi>
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> *Harshal Dhumal*
>>>>>>>> *Software Engineer *
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> EenterpriseDB <http://www.enterprisedb.com>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Sent via pgadmin-hackers mailing list (
>>>>>>>> pgadmin-hackers(at)postgresql(dot)org)
>>>>>>>> To make changes to your subscription:
>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>