Re: PATCH: To fix the issue in Database node (pgAdmin4)

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: George Gelashvili <ggelashvili(at)pivotal(dot)io>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To fix the issue in Database node (pgAdmin4)
Date: 2017-01-20 05:40:43
Message-ID: CAKKotZQonS_ZScTJwu8cZG7fBnQD3p9H1Df-DeShV9-P4o02Rw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Let me check

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 20, 2017 at 2:16 AM, George Gelashvili <ggelashvili(at)pivotal(dot)io>
wrote:

> Hi Dave and Murtuza,
>
> FYI - on our machines, running the DatabasesUpdateTestCase fails with an
> error after e431eb9d8ecc28572b39d26c9effcf66f70f6ae1:
>
> Traceback (most recent call last):
> File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/
> server_groups/servers/databases/tests/test_db_put.py", line 58, in runTest
> self.db_id)
> File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/
> server_groups/servers/databases/tests/utils.py", line 149, in
> disconnect_database
> assert db_con.status_code == 200
> AssertionError
>
> - Tira & George
>
>
> On Mon, Jan 16, 2017 at 10:43 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Fri, Jan 13, 2017 at 10:00 AM, Murtuza Zabuawala
>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>> > Hi Dave,
>> >
>> > I am not able to re-produce it, I reviewed reconnect to database logic
>> and
>> > it is not affected by this patch, Would you please provide me exact
>> steps?
>>
>> Weird, neither can I now. I guess something was messed up in my
>> environment then.
>>
>> Patch applied - sorry for the noise!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Harshal Dhumal 2017-01-20 07:03:44 Re: Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]
Previous Message George Gelashvili 2017-01-19 23:15:04 Re: Acceptance Tests against a browser (WIP)