Re: PATCH: To fix the issue in Database node (pgAdmin4)

From: George Gelashvili <ggelashvili(at)pivotal(dot)io>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To fix the issue in Database node (pgAdmin4)
Date: 2017-01-19 20:46:23
Message-ID: CAHowoHZ=OHFXa52=MDCPvQ6w0M=D58D8uaeQk6Nn7MVZcKHb7w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave and Murtuza,

FYI - on our machines, running the DatabasesUpdateTestCase fails with an
error after e431eb9d8ecc28572b39d26c9effcf66f70f6ae1:

Traceback (most recent call last):
File
"/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/test_db_put.py",
line 58, in runTest
self.db_id)
File
"/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/utils.py",
line 149, in disconnect_database
assert db_con.status_code == 200
AssertionError

- Tira & George

On Mon, Jan 16, 2017 at 10:43 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Fri, Jan 13, 2017 at 10:00 AM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> > Hi Dave,
> >
> > I am not able to re-produce it, I reviewed reconnect to database logic
> and
> > it is not affected by this patch, Would you please provide me exact
> steps?
>
> Weird, neither can I now. I guess something was messed up in my
> environment then.
>
> Patch applied - sorry for the noise!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message George Gelashvili 2017-01-19 22:07:44 Re: Acceptance Tests against a browser (WIP)
Previous Message Shirley Wang 2017-01-19 15:55:41 [PlumAdmin] Desktop vs web app