Re: [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][PATCH] To fix the issue in handling of timestamp type
Date: 2017-01-31 05:19:19
Message-ID: CAKKotZQmuH7Vm8on6BL9Bdv96wY53mpcFx5Nz_B5iEna6JhoSg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jan 30, 2017 at 8:07 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Can you rebase this please?
>
> Thanks.
>
> On Mon, Jan 30, 2017 at 5:37 AM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > Please find a patch to fix the issue in timestamp & time type when user
> > tries to provide scale/lengt to them.
> > I did some refactoring in code to handle it at one place, affected nodes
> > would be Type, Table & Column.
> > RM#2076
> >
> >
> > --
> > Regards,
> > Murtuza Zabuawala
> > EnterpriseDB: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
fix_timestamp_type_issue_v2.patch application/octet-stream 28.5 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2017-01-31 05:25:47 [pgAdmin4][Patch] Minor fix in test file for the Template loader
Previous Message Atira Odhner 2017-01-30 21:23:15 Re: Acceptance Tests against a browser (WIP)