From: | Atira Odhner <aodhner(at)pivotal(dot)io> |
---|---|
To: | George Gelashvili <ggelashvili(at)pivotal(dot)io> |
Cc: | Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Acceptance Tests against a browser (WIP) |
Date: | 2017-01-30 21:23:15 |
Message-ID: | CA+Vc24rpjYertAeAqK0T5eXAe=oGOCg2y09gNshgamih1KrOMg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Here's the patch with one more fix -- cleaning up the connections that get
created in pgAdmin.
On Mon, Jan 30, 2017 at 2:28 PM, George Gelashvili <ggelashvili(at)pivotal(dot)io>
wrote:
> so, it sounds like you're saying our accaptable_test_db is unacceptable :-P
>
> here's a patch that takes an "--exclude" flag (see README) and doesn't
> create dbs that don't get cleaned up afterwards
>
> On Fri, Jan 27, 2017 at 11:28 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> On Fri, Jan 27, 2017 at 4:11 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> > On Thu, Jan 26, 2017 at 10:40 PM, George Gelashvili
>> > <ggelashvili(at)pivotal(dot)io> wrote:
>> >> instead of that patch, please use this no-zombies version that kills
>> the
>> >> started process group instead of pid-only.
>> >
>> > Very cool :-). The only minor annoyance for me is that my Mac pops up
>> > a message asking me if I want pgAdmin to accept connections, but
>> > there's nothing you can do about that of course.
>> >
>> > At this point I think there are a couple of things left to do;
>> >
>> > - Add more tests!
>> >
>> > - Add command line options to runtests.py to allow users to run either
>> > the existing tests or the acceptance tests (or both, which should be
>> > the default). Of course, it should still be possible to just run any
>> > single test.
>>
>> Please add:
>>
>> - Proper cleanup. I just noticed the tests have left an
>> "acceptable_test_db" database behind.
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
Attachment | Content-Type | Size |
---|---|---|
acceptance-tests-with-exclude-and-connection-cleanup.diff | text/plain | 18.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2017-01-31 05:19:19 | Re: [pgAdmin4][PATCH] To fix the issue in handling of timestamp type |
Previous Message | George Gelashvili | 2017-01-30 19:28:19 | Re: Acceptance Tests against a browser (WIP) |