Re: [pgAdmin4][Patch]: Fixed RM #2489: Copy from the results grid is extremely slow and fails with large datasets

Hi Harshal,

Clipboard API won't work with IE11 & Edge browser Link
<https://developer.microsoft.com/en-us/microsoft-edge/platform/status/clipboardapi/>

[image: Inline image 1]

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jun 30, 2017 at 6:44 PM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

>
>
> On Fri, Jun 30, 2017 at 6:34 PM, Harshal Dhumal <
> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find attached updated patch. In this I have fixed js linter
>> related issues.
>>
>> Harshal, if we are settings clipboard data directly then do we need
> textarea control?
>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, Jun 30, 2017 at 4:29 PM, Harshal Dhumal <
>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave,
>>>
>>> Please find attached patch to fix copy large data to clipboard and
>>> improve copy/paste operation.
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Sr. Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Fri, Jun 30, 2017 at 2:33 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Hi
>>>>
>>>> So I tried this again on my main machine, but this time I see:
>>>>
>>>> (pgadmin4)piranha:web dpage$ yarn run bundle
>>>> yarn run v0.24.6
>>>> $ yarn run linter && yarn run webpacker
>>>> yarn run v0.24.6
>>>> $ yarn run eslint pgadmin/static/jsx/**/*.jsx
>>>> pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx
>>>> regression/javascript/**/*.js *.js
>>>> yarn run v0.24.6
>>>> $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint"
>>>> pgadmin/static/jsx/history/query_history.jsx
>>>> pgadmin/static/jsx/history/query_history_detail.jsx
>>>> pgadmin/static/jsx/history/query_history_entry.jsx
>>>> pgadmin/static/js/selection/active_cell_capture.js
>>>> pgadmin/static/js/selection/clipboard.js pgadmin/static/js/selection/column_selector.js
>>>> pgadmin/static/js/selection/copy_data.js pgadmin/static/js/selection/grid_selector.js
>>>> pgadmin/static/js/selection/range_boundary_navigator.js
>>>> pgadmin/static/js/selection/range_selection_helper.js
>>>> pgadmin/static/js/selection/row_selector.js
>>>> pgadmin/static/js/selection/set_staged_rows.js
>>>> pgadmin/static/js/selection/xcell_selection_model.js
>>>> regression/javascript/history/query_history_spec.jsx
>>>> regression/javascript/browser/menu_spec.js
>>>> regression/javascript/history/history_collection_spec.js
>>>> regression/javascript/selection/active_cell_capture_spec.js
>>>> regression/javascript/selection/column_selector_spec.js
>>>> regression/javascript/selection/copy_data_spec.js
>>>> regression/javascript/selection/grid_selector_spec.js
>>>> regression/javascript/selection/range_boundary_navigator_spec.js
>>>> regression/javascript/selection/range_selection_helper_spec.js
>>>> regression/javascript/selection/row_selector_spec.js
>>>> regression/javascript/selection/set_staged_rows_spec.js
>>>> regression/javascript/selection/xcell_selection_model_spec.js
>>>> regression/javascript/slickgrid/cell_selector_spec.js karma.conf.js
>>>> webpack.config.js webpack.test.config.js
>>>>
>>>> /Users/dpage/git/pgadmin4/web/pgadmin/static/js/selection/clipboard.js
>>>> 49:7 error '$' is not defined no-undef
>>>>
>>>> ✖ 1 problem (1 error, 0 warnings)
>>>>
>>>>
>>>> On Thu, Jun 29, 2017 at 1:40 PM, Khushboo Vashi <
>>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> I haven't come across this error while development as I tested the
>>>>> patch with Javascript debugger on.
>>>>> When I put a single break-point and then execute the code, it's giving
>>>>> the perfect output but not without a debugger.
>>>>>
>>>>> I have been trying to find the solution since yesterday but couldn't.
>>>>> I have tried many things but didn't work for me.
>>>>> So, if anyone has any clue please let me know as I am still trying.
>>>>>
>>>>> Thanks,
>>>>> Khushboo
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> On Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <
>>>>>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>>>>>
>>>>>>> Hi Khushboo,
>>>>>>>
>>>>>>> I applied your patch and tried to copy result from grid but got
>>>>>>> below exception.
>>>>>>> [image: Inline image 1]
>>>>>>> Also when I pressed copy button to copy 100k rows the browser was
>>>>>>> unresponsive for ~18 seconds (though copy operation was failed).
>>>>>>>
>>>>>>
>>>>>> Yes, I see the same error, no noticeable speedup, and nothing left on
>>>>>> the clipboard.
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> *Harshal Dhumal*
>>>>>>> *Sr. Software Engineer*
>>>>>>>
>>>>>>> EnterpriseDB India: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>> On Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <
>>>>>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Please find the attached patch to fix the RM #2489: Copy from the
>>>>>>>> results grid is extremely slow and fails with large datasets.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Khushboo
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>