| From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin4][RM#3062] Fix PEP-8 issues in Tools module |
| Date: | 2018-01-26 13:26:32 |
| Message-ID: | CAKKotZQUm_Bufs-Gn1K-w0wTM7s0PZZG86MxK=Yo7DWf7mdZWQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
PFA patch to fix PEP-8 issues in Tools module's python code.
How to run,
1) Apply patch RM#3063
2) activate virtual environemt
3) Install pycodestyle <https://pypi.python.org/pypi/pycodestyle> (formerly
called pep8) module from requirements.txt
4) Navigate to ../web directory and run following
pycodestyle --config=.pycodestyle ./pgadmin/tools
In step-4, you can also run yarn run pep8 for whole project but as of now I
have fixed only tools module, that's why I'm suggesting you to run it
against Tools module only :)
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| RM_3062.diff | text/plain | 140.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Murtuza Zabuawala | 2018-01-26 13:26:36 | [pgAdmin4][RM#3063] Add 'pycodestyle ' Python PEP-8 checker module |
| Previous Message | Dave Page | 2018-01-26 11:49:42 | pgAdmin 4 commit: Include a hash of the executable path in the lock and |