From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][RM#3062] Fix PEP-8 issues in Tools module |
Date: | 2018-01-26 16:56:41 |
Message-ID: | CA+OCxoz6ObqavtUepA+XFADfJY=NiSQ0xkvHHVSAG11+-8VHKg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Fri, Jan 26, 2018 at 1:26 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch to fix PEP-8 issues in Tools module's python code.
>
> How to run,
> 1) Apply patch RM#3063
> 2) activate virtual environemt
> 3) Install pycodestyle <https://pypi.python.org/pypi/pycodestyle> (formerly
> called pep8) module from requirements.txt
> 4) Navigate to ../web directory and run following
> pycodestyle --config=.pycodestyle ./pgadmin/tools
>
> In step-4, you can also run yarn run pep8 for whole project but as of now
> I have fixed only tools module, that's why I'm suggesting you to run it
> against Tools module only :)
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2018-01-26 17:03:39 | Re: [pgAdmin4][RM#3063] Add 'pycodestyle ' Python PEP-8 checker module |
Previous Message | Dave Page | 2018-01-26 16:54:24 | pgAdmin 4 commit: Fix PEP8 issues in the Tools module. Fixes #3063 |