Re: PATCH: Enhancement in SQL Field Backform control (pgAdmin4)

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Enhancement in SQL Field Backform control (pgAdmin4)
Date: 2016-12-16 14:29:22
Message-ID: CAKKotZQ=Qain7vU_jLz9f2idzKGfA=pcb00BTn-7P4opKkA-HQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

PFA updated patch with suggested changes, I only thought of SqlFieldControl
but yes we can use the same configuration everywhere.

Please review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Dec 16, 2016 at 6:38 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Fri, Dec 16, 2016 at 9:17 AM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > PFA minor patch to allow SQL field Backform Control to wrap code.
> > There is no open RM for this, it's just a small enhancement to control
> (PFA
> > screenshot for reference).
>
> Wouldn't this be better as an option under File->Preferences->SQL
> Editor->Options affecting all SQL fields (including the query tool)?
> It seems like it should be consistent, and optional.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
allow_line_wrapping_v1.patch application/octet-stream 6.2 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-12-16 17:05:07 Re: [pgAdmin4][Patch]: RM 1780: Rendering glitches in the query editor line number column when editing many lines
Previous Message Dave Page 2016-12-16 13:38:28 Re: [pgAdmin4][Patch]: RM #1807 Query Tool Does Not Recognize When File Changes Have Been Saved