Re: PATCH: Enhancement in SQL Field Backform control (pgAdmin4)

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Enhancement in SQL Field Backform control (pgAdmin4)
Date: 2016-12-16 17:11:02
Message-ID: CA+OCxozC2UqXU2ZXYUpLNLFZoPXZF49zTO+PxQBxb+Akjc=c6g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Fri, Dec 16, 2016 at 2:29 PM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> PFA updated patch with suggested changes, I only thought of SqlFieldControl
> but yes we can use the same configuration everywhere.
>
> Please review.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Dec 16, 2016 at 6:38 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> On Fri, Dec 16, 2016 at 9:17 AM, Murtuza Zabuawala
>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>> > Hi,
>> >
>> > PFA minor patch to allow SQL field Backform Control to wrap code.
>> > There is no open RM for this, it's just a small enhancement to control
>> > (PFA
>> > screenshot for reference).
>>
>> Wouldn't this be better as an option under File->Preferences->SQL
>> Editor->Options affecting all SQL fields (including the query tool)?
>> It seems like it should be consistent, and optional.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Harshal Dhumal 2016-12-16 18:46:34 Re: Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]
Previous Message Dave Page 2016-12-16 17:07:45 pgAdmin 4 commit: Allow users to enable wrapping of code in SQL boxes.