Re: [pgAdmin4][Patch]: Adding connection status in Query tool

Hi,

PFA updated patch based on new design suggested by Chethana.
The patch also includes some misc fixes related to object validation.
RM#2475

Please review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Dec 22, 2017 at 11:53 AM, Chethana Kumar <
chethana(dot)kumar(at)enterprisedb(dot)com> wrote:

> Yes Dave.
>
> Now it is clearly differentiated, please check and confirm.
>
> Thanks,
> Chethana kumar
>
> On Fri, Dec 22, 2017 at 12:08 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> There are 2 icons that look the same except for colour. That’s not going
>> to work for some users with colour blindness.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK:http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On 21 Dec 2017, at 15:32, Chethana Kumar <chethana(dot)kumar(at)enterprisedb(dot)com>
>> wrote:
>>
>> Hi Team,
>>
>> I have refined the icon once again for database connection status in
>> query tool itself.
>>
>> Below are the 5 different status that I have attached as screenshot -
>>
>> 1_busy
>> 2_error_in_transaction
>> 3_valid_transaction_in_idle
>> 4_database_connected
>> 5_database_disconnected
>>
>> Please provide your inputs.
>>
>> Regards,
>> Chethana kumar
>>
>>
>> On Tue, Dec 19, 2017 at 5:12 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to add the connection status
>>> <http://initd.org/psycopg/docs/extensions.html#transaction-status-constants>
>>> in query tool, this feature will allow user to check the database
>>> connection status in query tool itself, it will also provide the detailed
>>> status as a tooltip when user hovers on it, the most benefit of the feature
>>> will be when user open query tool in new Browser Tab where Browser tree is
>>> not visible to user, user can also configure the status polling time using
>>> preference dialog.
>>> RM#2475
>>>
>>> Apart from that I have also removed the ..sqleditor/static/css/sqledit
>>> or.css reference from ../datagrid/templates/datagrid/index.html file
>>> because we are already bundling the "sqleditor.css" file in main
>>> "style.css" file.
>>>
>>>
>>> Thanks to Chethana for his UI related inputs and to Surinder for helping
>>> me on html alignment issues.
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>>
>> --
>> Chethana Kumar
>> Principal UI/UX Designer
>> EnterpriseDB Corporation
>>
>>
>> The Postgres Database Company
>>
>> P: +91 86981 57146
>> www.enterprisedb.com
>>
>> <1_busy.jpg>
>>
>> <2_error_in_transaction.jpg>
>>
>> <3_valid_transaction_in_idle.jpg>
>>
>> <4_database_connected.jpg>
>>
>> <5_database_disconnected.jpg>
>>
>>
>
>
> --
> Chethana Kumar
> Principal UI/UX Designer
> EnterpriseDB Corporation
>
>
> The Postgres Database Company
>
> P: +91 86981 57146
> www.enterprisedb.com
>