Re: PATCH: To fix salt generation in session.py

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To fix salt generation in session.py
Date: 2016-07-11 11:00:53
Message-ID: CAKKotZQ+bG5P2Jmr-A93hmqps8AuRX=PTD69dOWmxgU9Q-ZQFg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Tested, I'm able to login now.

Thanks,
Murtuza

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jul 11, 2016 at 4:05 PM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> Hi Murtuza,
>
> Can you please test this patch for the same?
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
> On Mon, Jul 11, 2016 at 12:44 PM, Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please hold on in this patch, Need additional changes.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Mon, Jul 11, 2016 at 12:41 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> With latest pull session.py fails with below error with python3 because
>>> in python3 strings 'lowercase' method has been renamed to
>>> 'ascii_lowercase', PFA patch to fix the issue.
>>>
>>> Issue:
>>> ----------
>>> * File "../pgadmin4/web/pgadmin/utils/session.py", line 59, in sign*
>>> * self.randval =
>>> ''.join(random.sample(string.lowercase+string.digits, 20))*
>>> *AttributeError: module 'string' has no attribute 'lowercase'*
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-07-11 11:02:38 pgAdmin 4 commit: [Python 3 compability] Allow to run the auto-discover
Previous Message Ashesh Vashi 2016-07-11 10:35:15 Re: PATCH: To fix salt generation in session.py