From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: To fix salt generation in session.py |
Date: | 2016-07-11 11:03:09 |
Message-ID: | CAG7mmowMzvsgaD4X5k-oG=RDv9rESeGr2hSnmyEiR6QFbh_rDA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
I've committed the patch.
Thanks for testing it.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>
On Mon, Jul 11, 2016 at 4:30 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Tested, I'm able to login now.
>
>
> Thanks,
> Murtuza
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, Jul 11, 2016 at 4:05 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Murtuza,
>>
>> Can you please test this patch for the same?
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>> On Mon, Jul 11, 2016 at 12:44 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please hold on in this patch, Need additional changes.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Mon, Jul 11, 2016 at 12:41 PM, Murtuza Zabuawala <
>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> With latest pull session.py fails with below error with python3 because
>>>> in python3 strings 'lowercase' method has been renamed to
>>>> 'ascii_lowercase', PFA patch to fix the issue.
>>>>
>>>> Issue:
>>>> ----------
>>>> * File "../pgadmin4/web/pgadmin/utils/session.py", line 59, in sign*
>>>> * self.randval =
>>>> ''.join(random.sample(string.lowercase+string.digits, 20))*
>>>> *AttributeError: module 'string' has no attribute 'lowercase'*
>>>>
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-07-11 11:36:50 | Re: [Patch] Fix Unicode in errmsg |
Previous Message | Ashesh Vashi | 2016-07-11 11:02:38 | pgAdmin 4 commit: [Python 3 Compability] Made changes to make the new s |