Re: [HACKERS] path toward faster partition pruning

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] path toward faster partition pruning
Date: 2017-12-07 10:48:19
Message-ID: CAKJS1f_yO3nytivqsMQMnyOMG6vU6FOMdz8HLqispEY+eApLOg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 30 November 2017 at 11:15, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Committed 0004 after reviewing the code and testing that it seems to
> work as advertised.
>
> 0005 looks like it might need to be split into smaller patches. More
> broadly, the commit messages you wrote for for 0005, 0006, and 0008
> don't seem to me to do a great job explaining the motivation for the
> changes which they make. They tell me what the patches do, but not
> why they are doing it. If there's an email in this thread that
> explains that stuff, please point me to it and I'll go back and reread
> it more carefully; if not, I think I definitely need some more
> explanation both of the mission of each patch and the reason why the
> patch set is divided up in the way that it is.

Hi Amit,

It looks like just 0005 to 0008 remain of this and I see that the v13
0005 patch no longer applies to current master.

Are you working on splitting this up as requested by Robert above?

I can continue reviewing this once patches are available that apply to
current master.

Many thanks

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Beena Emerson 2017-12-07 10:56:14 Re: [HACKERS] Runtime Partition Pruning
Previous Message David Rowley 2017-12-07 10:37:51 Re: [HACKERS] Runtime Partition Pruning