Re: [Sender Address Forgery]Re: [HACKERS] path toward faster partition pruning

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [Sender Address Forgery]Re: [HACKERS] path toward faster partition pruning
Date: 2017-12-08 00:46:43
Message-ID: 4a40a579-18fe-77aa-6d2a-5785fe1f025d@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi David.

On 2017/12/07 19:48, David Rowley wrote:
> On 30 November 2017 at 11:15, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Committed 0004 after reviewing the code and testing that it seems to
>> work as advertised.
>>
>> 0005 looks like it might need to be split into smaller patches. More
>> broadly, the commit messages you wrote for for 0005, 0006, and 0008
>> don't seem to me to do a great job explaining the motivation for the
>> changes which they make. They tell me what the patches do, but not
>> why they are doing it. If there's an email in this thread that
>> explains that stuff, please point me to it and I'll go back and reread
>> it more carefully; if not, I think I definitely need some more
>> explanation both of the mission of each patch and the reason why the
>> patch set is divided up in the way that it is.
>
> Hi Amit,
>
> It looks like just 0005 to 0008 remain of this and I see that the v13
> 0005 patch no longer applies to current master.
>
> Are you working on splitting this up as requested by Robert above?
>
> I can continue reviewing this once patches are available that apply to
> current master.

I'm still working on that. I will be able to submit a new version
sometime early in the next week, that is, if I don't manage to do it by
today evening (Japan time). Sorry that it's taking a bit longer.

Thanks,
Amit

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2017-12-08 00:54:48 Re: Add %r substitution for psql prompts to show recovery status
Previous Message Thomas Munro 2017-12-08 00:33:11 Re: [HACKERS] SERIALIZABLE with parallel query