| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix compiler warnings in Cube Extension |
| Date: | 2015-12-28 21:52:46 |
| Message-ID: | CAKJS1f_jGJ3N_rB2bHBnq3aXUYMTJR+VNQ_Mz479GEkZFpJ0mA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 29 December 2015 at 07:38, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> > My compiler is complaining about cube_coord() and cube_coord_llur() not
> > returning a value on all code paths.
>
> Yeah, looking at that code, this would be expected from any compiler
> that doesn't know that ereport() doesn't return. On it now. The
> documentation aspect of that commit leaves much to be desired as well.
>
Great. Thanks for committing.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-12-28 22:12:21 | Re: Avoid endless futile table locks in vacuuming. |
| Previous Message | Chapman Flack | 2015-12-28 21:41:27 | Re: missing "SPI_finish" that isn't missing |