Re: Fix compiler warnings in Cube Extension

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix compiler warnings in Cube Extension
Date: 2015-12-28 18:38:11
Message-ID: 21064.1451327891@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> My compiler is complaining about cube_coord() and cube_coord_llur() not
> returning a value on all code paths.

Yeah, looking at that code, this would be expected from any compiler
that doesn't know that ereport() doesn't return. On it now. The
documentation aspect of that commit leaves much to be desired as well.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2015-12-28 19:15:31 Re: On columnar storage (2)
Previous Message Joe Conway 2015-12-28 18:35:18 Re: oldest/newestCommitTs output by pg_controldata