Re: A small tweak to some comments for PartitionKeyData

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: A small tweak to some comments for PartitionKeyData
Date: 2018-10-25 04:13:43
Message-ID: CAKJS1f9mTF3yJHe2inW8JzFdWLZNf-_JJCaZY3vnwr6N3ouN8A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 25 October 2018 at 17:05, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> On 2018/10/25 12:54, David Rowley wrote:
>> On 25 October 2018 at 16:46, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>> + * key, one for each zero-valued partattrs */
>>>
>>> How about: for each zero-valued member of partattrs?
>>
>> Aren't arrays made up of elements? I did have "element" on the end,
>> but I didn't think it was worth having the extra line caused by the 80
>> line length limit, so I deleted it.
>>
>> Seems "element" is mentioned 73 times in [1], but "member" does not
>> get a mention.
>>
>> [1] https://en.wikipedia.org/wiki/Array_data_structure
>
> I thought they can be used interchangeably, but perhaps not.

A struct or a class has members.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2018-10-25 04:19:02 Re: A small tweak to some comments for PartitionKeyData
Previous Message Amit Langote 2018-10-25 04:05:34 Re: A small tweak to some comments for PartitionKeyData