Re: A small tweak to some comments for PartitionKeyData

On 2018/10/25 12:54, David Rowley wrote:
> On 25 October 2018 at 16:46, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> + * key, one for each zero-valued partattrs */
>>
>> How about: for each zero-valued member of partattrs?
>
> Aren't arrays made up of elements? I did have "element" on the end,
> but I didn't think it was worth having the extra line caused by the 80
> line length limit, so I deleted it.
>
> Seems "element" is mentioned 73 times in [1], but "member" does not
> get a mention.
>
> [1] https://en.wikipedia.org/wiki/Array_data_structure

I thought they can be used interchangeably, but perhaps not.

Anyway, it's just that "each zero-valued partattrs" sounds a bit odd to
me, especially because it you seem to be referring to the previous array
field 'partattrs'. It would've sounded better with "each zero-valued
partition attribute", for example, but again that's too long for the line too.

Thanks,
Amit