| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Clarify use of temporary tables within partition trees |
| Date: | 2018-07-03 06:00:46 |
| Message-ID: | CAKJS1f8f8+3FOBhSoopo15uzHsY76+L8cMKhMwBi+x+bvBU7tg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 3 July 2018 at 16:55, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Okay, the patch looks logically correct to me, I just tweaked the
> comments as per the attached. I would also back-patch that down to v11
> to keep the code consistent with HEAD.. What do you think?
Thanks for fixing it up. It looks fine apart from "Temporation" should
be "Temporary".
I think it should be backpatched to v11 and v10. Your original commit
went there too. I don't see any reason to do any different here than
what you did with the original commit.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-07-03 06:11:19 | Re: pgsql: Clarify use of temporary tables within partition trees |
| Previous Message | Michael Paquier | 2018-07-03 04:55:02 | Re: pgsql: Clarify use of temporary tables within partition trees |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2018-07-03 06:04:23 | Re: Should contrib modules install .h files? |
| Previous Message | Alvaro Herrera | 2018-07-03 05:17:48 | Re: Possible bug in logical replication. |