Re: pgsql: Clarify use of temporary tables within partition trees

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Clarify use of temporary tables within partition trees
Date: 2018-07-03 04:55:02
Message-ID: 20180703045502.GA26236@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Jul 03, 2018 at 12:59:33PM +1200, David Rowley wrote:
> On 3 July 2018 at 10:16, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> On Mon, Jul 02, 2018 at 02:07:37PM -0400, Robert Haas wrote:
>>> I'd rather keep an elog(ERROR) than completely remove the check.
>>
>> +1.
>
> Attached

Okay, the patch looks logically correct to me, I just tweaked the
comments as per the attached. I would also back-patch that down to v11
to keep the code consistent with HEAD.. What do you think?
--
Michael

Attachment Content-Type Size
remove_dead_code_from_expand_partitioned_rtentry_v3.patch text/x-diff 2.1 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2018-07-03 06:00:46 Re: pgsql: Clarify use of temporary tables within partition trees
Previous Message Robert Haas 2018-07-03 01:07:58 Re: pgsql: Clarify use of temporary tables within partition trees

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-07-03 05:17:48 Re: Possible bug in logical replication.
Previous Message Craig Ringer 2018-07-03 04:43:50 Re: Should contrib modules install .h files?