From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila(at)enterprisedb(dot)com> |
Subject: | Re: Combining Aggregates |
Date: | 2016-03-25 03:53:30 |
Message-ID: | CAKJS1f-5_QtXPC4VUbkqYqYoAJ79qhvmxo0JON05EokOCgn0AA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 25 March 2016 at 06:17, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, Mar 21, 2016 at 2:18 PM, David Rowley
> <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
>> I've attached 2 of the patches which are affected by the changes.
>
> I think the documentation for 0001 needs some work yet. The
> additional paragraph that you've added...
>
> (1) doesn't seem to appear at a very logical place in the
> documentation - I think it should be much further down, as it's a
> minor detail. Maybe document this the same way as the documentation
> patch you just sent for the combine-function stuff does it; and
Thanks. I also realised this when writing the combine documents fix.
> (2) isn't indented consistently with the surrounding paragraphs; and
>
> (3) is missing a closing </para> tag
>
> Also, I'd just cut this:
>
> + This is required due to
> + the process model being unable to pass references to <literal>INTERNAL
> + </literal> types between different <productname>PostgreSQL</productname>
> + processes.
>
> Instead, I'd change the earlier sentence in the paragraph, which
> currently reads:
>
> + These
> + functions are required in order to allow parallel aggregation for aggregates
> + with an <replaceable class="PARAMETER">stype</replaceable> of <literal>
> + INTERNAL</>.
>
> I'd replace the period at end with a comma and add "since
> <literal>INTERNAL</> values represent arbitrary in-memory data
> structures which can't be passed between processes". I think that's a
> bit smoother.
>
In my rewrite I've incorporated these words.
Thanks for checking over this. A patch will follow in my response to
the next email.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-03-25 03:55:42 | Re: Rationalizing code-sharing among src/bin/ directories |
Previous Message | Michael Paquier | 2016-03-25 03:44:43 | Re: Rationalizing code-sharing among src/bin/ directories |