Re: Rationalizing code-sharing among src/bin/ directories

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Rationalizing code-sharing among src/bin/ directories
Date: 2016-03-25 03:55:42
Message-ID: 28517.1458878142@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> Not sure if Andres is working on that for now or not, the main
> discussion that I am foreseeing here is how we are going to map elevel
> for the frontend (should FATAL, PANIC exit immediately, etc).

Doesn't seem that complicated to me: elevel >= ERROR results in exit(1),
otherwise just print to stderr and return. We'd be eyeballing each case
that we remove "#ifndef FRONTEND" from anyway; if it's expecting behavior
noticeably more complicated than that, we could leave it as-is.

> Stability of 9.6 is first and just ahead.

Agreed, this is code cleanup not a high priority.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2016-03-25 03:59:34 Re: Performance degradation in commit 6150a1b0
Previous Message David Rowley 2016-03-25 03:53:30 Re: Combining Aggregates