From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Parallelized polymorphic aggs, and aggtype vs aggoutputtype |
Date: | 2016-06-22 21:51:09 |
Message-ID: | CAKJS1f-4=nO+nZoGC8RKsCj8gjwrmpXVKNVPrUidQK75M-V+0w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 23 June 2016 at 08:53, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
>>> I've gone and implemented the dummy argument approach for
>>> deserialization functions.
>
>> How do you feel about the further idea of locking down the signatures
>> to be exactly "serialize(internal) returns bytea" and "deserialize(bytea,
>> internal) returns internal", and removing pg_aggregate.aggserialtype?
>> I don't see very much value in allowing any other nominal transmission
>> type besides bytea; and the less flexibility in these function signatures,
>> the less chance of confusion/misuse of other internal-related functions.
I don't object to removing it. If we find a use for non-bytea serial
types down the line, then we can add it again.
> Not hearing any objections, pushed that way.
Many thanks for committing those fixes.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Craig Ringer | 2016-06-22 22:43:58 | Re: how is the WAL receiver process stopped and restarted when the network connection is broken and then restored? |
Previous Message | Alvaro Herrera | 2016-06-22 21:32:56 | Re: MultiXactId error after upgrade to 9.3.4 |