Re: general purpose array_sort

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "andreas(at)proxel(dot)se" <andreas(at)proxel(dot)se>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>
Subject: Re: general purpose array_sort
Date: 2024-09-29 02:50:38
Message-ID: CAKFQuwboJXRuVerHTWyPiCNazTQGr8LyCCyR_SZ6_=3iDNjr6w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Sep 28, 2024 at 7:05 PM Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:

> On Sat, Sep 28, 2024 at 10:41 PM jian he <jian(dot)universality(at)gmail(dot)com>
> wrote:
> >
> > <parameter>dir</parameter> can have only two potential values, make it
> > as a boolean would be more easier?
> > you didn't mention information: "by default, it will sort by
> > ascending order; the sort collation by default is using the array
> > element type's collation"
> >
> > tuplesort_begin_datum can do null-first, null-last, so the
> > one-dimension array can allow null values.
>
> The following(create extension intarry first) will give an error, I
> keep the same for array_sort.
>
> SELECT sort('{1234234,-30,234234, null}');
>
>
I would suggest accepting:
asc
desc
asc nulls first
asc nulls last *
desc nulls first *
desc nulls last

As valid inputs for "dir" - and that the starred options are the defaults
when null position is omitted.

In short, mimic create index.

David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2024-09-29 03:46:35 Re: Add has_large_object_privilege function
Previous Message Junwang Zhao 2024-09-29 02:05:34 Re: general purpose array_sort