Re: Stability of queryid in minor versions

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Stability of queryid in minor versions
Date: 2024-04-15 02:23:33
Message-ID: CAKFQuwaPQ6g-ea8L+Pcz2TjCaSaBSOkLWj=+kXKs=-z+JuAowA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Apr 14, 2024 at 7:03 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:

> On Mon, 15 Apr 2024 at 13:37, David G. Johnston
> <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> > Seems we can improve things by simply removing the "rule of thumb"
> sentence altogether. The prior paragraph states the things the queryid
> depends upon at the level of detail the reader needs.
>
> I don't think that addresses the following, which I mentioned earlier:
>
> > but not stable across *major* versions does *not* mean stable across
> > *minor* versions. The reader is just left guessing if that's true.
>
>
The base assumption here is that changes in the things we don't mention do
not influence the queryid. We didn't mention minor versions, changing them
doesn't influence the queryid.

Now, reading that entire paragraph is a bit of a challenge IMO, and agree,
as I subsequently noted, that the sentence you pointed out could be
reworked. I stand by my statement that removing the sentence about "rule
of thumb" altogether is a win. The prior paragraph should be sufficient -
it is technically at the moment but am not opposed to rewording.

David J.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2024-04-15 02:54:52 Re: Stability of queryid in minor versions
Previous Message David Rowley 2024-04-15 02:12:34 Re: Fix out-of-bounds in the function GetCommandTagName