| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Guyren Howe <guyren(at)gmail(dot)com>, Pg Docs <pgsql-docs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Please provide examples of rows from |
| Date: | 2020-09-30 03:53:51 |
| Message-ID: | CAKFQuwa=dXV4a_Hm=PfufJkhDR4uFwiG+ON-ea5wp=BGBJHQtQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
On Thu, Sep 24, 2020 at 12:37 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Thu, Sep 24, 2020 at 03:05:24PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > Yes, this is very helpful. I was afraid the JSON would overwhelm the
> > > example, but this looks good. I wrote the attached doc patch which I
> > > think improves this. I plan to apply it to all supported versions.
> >
> > Couple thoughts:
> >
> > * Taking the initial ... out of the syntax synopsis is not an
> improvement.
> > It makes it look like you can only apply AS to the first function of a
> > ROWS FROM.
>
> Oh, so the dots represent optional non-column_definition function calls.
> I can't think if a cleaner way to show that, so I guess "..." will have
> to do.
>
My original comment was a question predicated upon the fact that the SELECT
reference page doesn't include the leading; probably should add them there
as part of this patch.
OK, better. New patch attached.
>
LGTM
David J.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2020-09-30 17:54:32 | Re: Please provide examples of rows from |
| Previous Message | Tom Lane | 2020-09-29 19:28:50 | Re: Version 13 documentation layout is harder to read than version 12 |