Re: Please provide examples of rows from

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Guyren Howe <guyren(at)gmail(dot)com>, Pg Docs <pgsql-docs(at)lists(dot)postgresql(dot)org>
Subject: Re: Please provide examples of rows from
Date: 2020-09-30 17:54:32
Message-ID: 20200930175432.GB26841@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Tue, Sep 29, 2020 at 08:53:51PM -0700, David G. Johnston wrote:
> On Thu, Sep 24, 2020 at 12:37 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
> On Thu, Sep 24, 2020 at 03:05:24PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > Yes, this is very helpful.  I was afraid the JSON would overwhelm the
> > > example, but this looks good.  I wrote the attached doc patch which I
> > > think improves this.  I plan to apply it to all supported versions.
> >
> > Couple thoughts:
> >
> > * Taking the initial ... out of the syntax synopsis is not an
> improvement.
> > It makes it look like you can only apply AS to the first function of a
> > ROWS FROM.
>
> Oh, so the dots represent optional non-column_definition function calls.
> I can't think if a cleaner way to show that, so I guess "..." will have
> to do.
>
>
> My original comment was a question predicated upon the fact that the SELECT
> reference page doesn't include the leading; probably should add them there as
> part of this patch.

I looked at that but in the SELECT manual page case, the example is
already part of a larger list of options so I don't think it is needed.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message Michael Paquier 2020-10-02 01:39:04 Re: replication wordsmithing / clarifications
Previous Message David G. Johnston 2020-09-30 03:53:51 Re: Please provide examples of rows from