From: | David Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | "pgsql-docs(at)postgresql(dot)org" <pgsql-docs(at)postgresql(dot)org> |
Subject: | Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration? |
Date: | 2014-09-11 00:09:30 |
Message-ID: | CAKFQuwZ2-3k2h0Z6YJ0EbZRNVZtVQUAedccQGJ9JFMqSVeJJ1A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs pgsql-hackers |
On Wed, Sep 10, 2014 at 4:20 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Tue, Sep 9, 2014 at 03:40:45PM -0400, David Johnston wrote:
>
> > "In addition to setting global defaults or attaching" <- add a comma
> after
> > "defaults"
>
> I didn't like this change as it causes too many comma phrases.
>
> Attaches are the changes since yesterday's patch. The full patch is at:
>
> ftp://momjian.us/postgresql/mypatches/config.diff
>
>
At minimum the word "setting" in that paragraph needs to be made plural.
", you can pass settings to <productname>PostgreSQL..."
I'm not particularly fond of the overly long preamble burying the "shell
facilities" - and the resultant comma separating the two - but cannot think
of anything better. Not having the transition makes it too short and curt.
The proposed second comma helped to at least break it up but it too
doesn't sound all that great.
I'm good for just making the plural fix and calling it a day.
David J.
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2014-09-11 00:49:57 | Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration? |
Previous Message | John Lumby | 2014-09-10 21:51:32 | NULL as a (pseudo-)value not described? |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2014-09-11 00:10:45 | Re: "cancelling statement due to user request error" occurs but the transaction has committed. |
Previous Message | Bruce Momjian | 2014-09-10 23:25:12 | Re: pg_control is missing a field for LOBLKSIZE |