From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | David Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> |
Cc: | "pgsql-docs(at)postgresql(dot)org" <pgsql-docs(at)postgresql(dot)org> |
Subject: | Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration? |
Date: | 2014-09-10 20:20:02 |
Message-ID: | 20140910202002.GA21173@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs pgsql-hackers |
On Tue, Sep 9, 2014 at 03:40:45PM -0400, David Johnston wrote:
> Minor corrections:
>
> First block: "
> In the first section of this chapter, we
> describe how to set configuration parameters"
>
> - remove the comma
>
> Second Block:
> - placement of the colon inside or outside of the emphasis tag is inconsistent
> (string, unit, enum are inside; boolean and numeric are outside)
> - units: "An numeric value..." -> maybe "An unadorned numeric value...
>
> Third block:
> "Hash marks (<literal>#</literal>) designate the remainder of lines as
> comments." -> "...designate the remainder of the line as a comment." I read
> this at first as "remaining lines [in the file] ... "
>
> "To embed a single quote in a parameter value, write either two quotes
> (preferred) or backslash-quote." -> remove the comma
> "Querying this view is the sames as" -> "the same as"
I agree all of the above are improvements, and changed.
> "In addition to setting global defaults or attaching" <- add a comma after
> "defaults"
I didn't like this change as it causes too many comma phrases.
Attaches are the changes since yesterday's patch. The full patch is at:
ftp://momjian.us/postgresql/mypatches/config.diff
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
Attachment | Content-Type | Size |
---|---|---|
change.diff | text/x-diff | 4.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | John Lumby | 2014-09-10 21:51:32 | NULL as a (pseudo-)value not described? |
Previous Message | David Johnston | 2014-09-09 19:40:45 | Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration? |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2014-09-10 20:21:40 | Re: Support for N synchronous standby servers |
Previous Message | Robert Haas | 2014-09-10 20:01:07 | Re: pg_background (and more parallelism infrastructure patches) |