Re: Subscript expressions do not have to evaluate to integers

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, sean(at)materialize(dot)io, Pg Docs <pgsql-docs(at)lists(dot)postgresql(dot)org>
Subject: Re: Subscript expressions do not have to evaluate to integers
Date: 2020-08-22 02:21:30
Message-ID: CAKFQuwY_EtAVCRbu4HxDrHg1Wo0HMnD_uydFw=ZQzTMdDXDFqQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Fri, Aug 21, 2020 at 6:22 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > On Wed, Jul 22, 2020 at 02:59:18AM +0000, PG Doc comments form wrote:
> >> I believe a more appropriate statement would acknowledge that at least
> some
> >> values undergo an explicit-style conversion to an integer.
>
> > OK, how is the attached patch?
>
> "and" is not an improvement over "which". Otherwise seems OK.
>
> (The proposed patch for generic subscripting will probably need to
> rewrite this completely, but for now this is an improvement.)
>

I was going to add that maybe we should link to the round(dp or numeric)
function in the documentation and let it be explicit about the rounding
rules pertaining to half - which when I look isn't actually documented:

round(dp or numeric) (same as input) round to nearest integer

Maybe everyone just knows that rounding, unless otherwise stated, rounds
halves away from zero but it doesn't seem like a bad idea to be explicit.

David J.

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message David G. Johnston 2020-08-22 02:42:35 Re: Procedures
Previous Message David G. Johnston 2020-08-22 02:09:31 Re: Typo in the Section "3.6. Inheritance"