Re: Typo in the Section "3.6. Inheritance"

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, 2552891(at)gmail(dot)com, Pg Docs <pgsql-docs(at)lists(dot)postgresql(dot)org>
Subject: Re: Typo in the Section "3.6. Inheritance"
Date: 2020-08-22 02:09:31
Message-ID: CAKFQuwYPV+Aw9JjbO5CX-8D5AFbZkwH9zuWpSt53JEEWBi3_Ew@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Fri, Aug 21, 2020 at 4:36 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:

> On Wed, Aug 5, 2020 at 11:29:31PM -0700, David G. Johnston wrote:
>
> > Removing "char" from the tutorial is a nice side-effect that we probably
> want
> > to do even if we keep "state".
>
> I think CHAR(2) is fine because it is always 2 characters.
>

You imply "it is always two non-blank characters" though that isn't what
CHAR(2) means. Adding CHECK (state ~ '^[A-Z]{2}$') and leaving the type as
text would be best from a pure model perspective - but this isn't the place
to teach that and for the same reason char(2) isn't terrible.

How is the attached patch, based on your suggestions?
>

Works for me.

David J.

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message David G. Johnston 2020-08-22 02:21:30 Re: Subscript expressions do not have to evaluate to integers
Previous Message Michael Paquier 2020-08-22 01:36:46 Re: Typo in the Section "3.6. Inheritance"