From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Implement waiting for given lsn at transaction start |
Date: | 2020-04-07 21:45:59 |
Message-ID: | CAKFQuwYSscfbDNtQWHZY7Pin5WNPk1g7Z0qs_AfncVndeCOwLA@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Tue, Apr 7, 2020 at 2:27 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alexander Korotkov <akorotkov(at)postgresql(dot)org> writes:
> > Implement waiting for given lsn at transaction start
> > This commit adds following optional clause to BEGIN and START TRANSACTION
> > commands.
> > WAIT FOR LSN lsn [ TIMEOUT timeout ]
>
> This seems like a really carelessly chosen syntax --- *three* new
> keywords, when you probably didn't need any. Are you not aware that
> there is distributed overhead in the grammar for every keyword?
> Plus, each new keyword carries the risk of breaking existing
> applications, since it no longer works as an alias-not-preceded-by-AS.
>
> I have no particular opinion on the value of the feature, but I wish
> a different syntax had been chosen.
>
I was curious whether the syntax got this kind of discussion, followed the
discussion link, and the last email seen reads:
"""
> Worse, it was marked Needs Review even though no new patch was provided.
>
> I'm going to set this back to Returned with Feedback. If anyone has a
good
> reason that it should be in the CF we can always revive it.
+1.
"""
While there is lots of discussion it ended up with the thread at "returned
with feedback" (a month ago) and now we have a commit. There seems to be
other relevant discussion not linked to.
David J.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-04-07 21:46:34 | pgsql: Allow psql's \g and \gx commands to transiently change \pset opt |
Previous Message | Tom Lane | 2020-04-07 21:27:04 | Re: pgsql: Implement waiting for given lsn at transaction start |