Re: pgsql: Implement waiting for given lsn at transaction start

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alexander Korotkov <akorotkov(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Implement waiting for given lsn at transaction start
Date: 2020-04-07 21:27:04
Message-ID: 28209.1586294824@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alexander Korotkov <akorotkov(at)postgresql(dot)org> writes:
> Implement waiting for given lsn at transaction start
> This commit adds following optional clause to BEGIN and START TRANSACTION
> commands.
> WAIT FOR LSN lsn [ TIMEOUT timeout ]

This seems like a really carelessly chosen syntax --- *three* new
keywords, when you probably didn't need any. Are you not aware that
there is distributed overhead in the grammar for every keyword?
Plus, each new keyword carries the risk of breaking existing
applications, since it no longer works as an alias-not-preceded-by-AS.

I have no particular opinion on the value of the feature, but I wish
a different syntax had been chosen.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message David G. Johnston 2020-04-07 21:45:59 Re: pgsql: Implement waiting for given lsn at transaction start
Previous Message Alexander Korotkov 2020-04-07 20:54:53 pgsql: Implement waiting for given lsn at transaction start