| From: | Greg Sabino Mullane <htamfids(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | David Christensen <david+pg(at)pgguru(dot)net>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Adding comments to help understand psql hidden queries |
| Date: | 2024-03-22 14:46:48 |
| Message-ID: | CAKAnmmL6-U+QPsuWM0r8mNq0Lo80d8L=cR7JLk7pypXJfwt=EA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 21, 2024 at 6:20 PM Peter Eisentraut <peter(at)eisentraut(dot)org>
wrote:
> lines are supposed to align vertically. With your patch, the first line
> would have variable length depending on the command.
>
Yes, that is a good point. Aligning those would be quite tricky, what if we
just kept a standard width for the closing query? Probably the 24 stars we
currently have to match "QUERY", which it appears nobody has changed for
translation purposes yet anyway. (If I am reading the code correctly, it
would be up to the translators to maintain the vertical alignment).
Cheers,
Greg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-03-22 14:47:39 | Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs |
| Previous Message | Tomas Vondra | 2024-03-22 14:40:40 | Re: pg_upgrade --copy-file-range |