Re: Adding comments to help understand psql hidden queries

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: David Christensen <david+pg(at)pgguru(dot)net>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
Cc: Greg Sabino Mullane <htamfids(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adding comments to help understand psql hidden queries
Date: 2024-03-21 22:20:05
Message-ID: 8c9b9b7d-0868-46d4-963c-8b1906bd7a1b@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 21.03.24 18:31, David Christensen wrote:
> Thanks for the feedback. Enclosed is a v2 of this series(?) rebased
> and with that warning fixed; @Greg Sabino Mullane I just created a
> commit on your behalf with the message to hackers. I'm also creating
> a commit-fest entry for this thread.

I don't think your patch takes into account that the

/**... QUERY ...**/
...
/**... ...**/

lines are supposed to align vertically. With your patch, the first line
would have variable length depending on the command.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-03-21 22:29:43 Re: [PATCH] ltree hash functions
Previous Message Daniel Gustafsson 2024-03-21 22:10:37 Re: doc issues in event-trigger-matrix.html