Re: commitfest.postgresql.org is no longer fit for purpose

From: Greg Sabino Mullane <htamfids(at)gmail(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Joe Conway <mail(at)joeconway(dot)com>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: commitfest.postgresql.org is no longer fit for purpose
Date: 2024-05-17 17:12:59
Message-ID: CAKAnmmJ3eCdhH3j2qSr=mcXaOx-gSjxbOyGgAwk9H7uiLnvpWQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 17, 2024 at 7:11 AM Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
wrote:

> It does seem to me a part of the solution needs to be helping to get
> those patches reviewed. I don't know how to do that, but perhaps there's
> a way to encourage people to review more stuff, or review stuff from a
> wider range of contributors. Say by treating reviews more like proper
> contributions.

This is a huge problem. I've been in the situation before where I had some
cycles to do a review, but actually finding one to review is
super-difficult. You simply cannot tell without clicking on the link and
wading through the email thread. Granted, it's easy as an
occasional reviewer to simply disregard potential patches if the email
thread is over a certain size, but it's still a lot of work. Having some
sort of summary/status field would be great, even if not everything was
labelled. It would also be nice if simpler patches were NOT picked up by
experienced hackers, as we want to encourage new/inexperienced people, and
having some "easy to review" patches available will help people gain
confidence and grow.

> Long time ago there was a "rule" that people submitting patches are
> expected to do reviews. Perhaps we should be more strict this.
>

Big -1. How would we even be more strict about this? Public shaming?
Withholding a commit?

Cheers,
Greg

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2024-05-17 17:18:17 Re: broken tables on hot standby after migration on PostgreSQL 16 (3x times last month)
Previous Message Tom Lane 2024-05-17 17:09:55 Re: problems with "Shared Memory and Semaphores" section of docs