From: | Josh Kupershmidt <schmiddy(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: psql: tab completions for 'WITH' |
Date: | 2012-04-11 00:48:25 |
Message-ID: | CAK3UJRH8wr920zH3pL6w-TSN7K8aah1oDF7=cmvyx06sUBdn9A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Apr 10, 2012 at 10:38 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On tis, 2012-04-03 at 22:34 -0700, Josh Kupershmidt wrote:
>> I noticed psql's tab-completion for 'WITH' is a bit overeager. If you
>> try to tab-complete commands like:
>> ALTER ROLE jsmith WITH [TAB]
>> COPY tbl FROM 'filename' WITH [TAB]
>>
>> you'll get 'RECURSIVE' unhelpfully filled in. I think 'RECURSIVE'
>> should only be suggested if 'WITH' is the first and only word of the
>> line.
>
> Committed that.
Thanks!
>> On a related note, I found it annoying that after fixing the above
>> problem, trying:
>> ALTER ROLE jsmith WITH [TAB]
>> CREATE ROLE jsmith WITH [TAB]
>>
>> didn't suggest any tab-completions -- it only works if you leave off
>> the 'WITH' noise word, which I happen to use.
>
> Hmm, but now you've set it up so that you can complete ALTER ROLE foo
> WITH WITH. Were you aware of that?
D'oh, I overlooked that. Attached is v2: the diff is a tad lengthier
now, but that should fix it.
Josh
Attachment | Content-Type | Size |
---|---|---|
create_alter_role_tab_complete.v2.diff | application/octet-stream | 4.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2012-04-11 00:53:06 | Re: Patch: add timing of buffer I/O requests |
Previous Message | Bruce Momjian | 2012-04-11 00:47:28 | Re: pg_tablespace_location() error message |