Re: psql: tab completions for 'WITH'

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql: tab completions for 'WITH'
Date: 2012-04-10 17:38:36
Message-ID: 1334079516.1383.1.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On tis, 2012-04-03 at 22:34 -0700, Josh Kupershmidt wrote:
> I noticed psql's tab-completion for 'WITH' is a bit overeager. If you
> try to tab-complete commands like:
> ALTER ROLE jsmith WITH [TAB]
> COPY tbl FROM 'filename' WITH [TAB]
>
> you'll get 'RECURSIVE' unhelpfully filled in. I think 'RECURSIVE'
> should only be suggested if 'WITH' is the first and only word of the
> line.

Committed that.

> On a related note, I found it annoying that after fixing the above
> problem, trying:
> ALTER ROLE jsmith WITH [TAB]
> CREATE ROLE jsmith WITH [TAB]
>
> didn't suggest any tab-completions -- it only works if you leave off
> the 'WITH' noise word, which I happen to use.

Hmm, but now you've set it up so that you can complete ALTER ROLE foo
WITH WITH. Were you aware of that?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-04-10 17:44:55 Re: Patch: add timing of buffer I/O requests
Previous Message Robert Haas 2012-04-10 17:35:02 Re: Patch: add timing of buffer I/O requests