Re: pgAdmin III: Muliple SQL tabs

Added the query name to history entries. Please note that history entries
are not modified if user saves [Query 1] to file [foo.sql]. I don't think
that would be practical.

On Wed, Feb 10, 2016 at 8:28 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Wed, Feb 10, 2016 at 12:14 AM, Sergey Busel <sbusel(at)gmail(dot)com> wrote:
>
>> Dave,
>>
>> Here is a patch that does display the query tab name in the title bar of
>> the output pane. It seems to work with loading and saving the perspective,
>> too. The trick is to restore the original text on the output pane before
>> loading and saving the perspective, and put the query name back in there
>> right after.
>>
>> Attached is the full patch, not the diff from the previous patch I sent.
>> Let me know if you have other suggestions.
>>
>
> That seems to solve the problem nicely :-) - Thanks!
>
> It does lead to one other issue that I can see - the History tab on the
> results pane now shows the history for all query tabs, which seems a little
> odd given that the other 3 tabs on the results panel are query tab
> specific. Unless there are better ideas, I think the best way to fix this
> is to include the current tab name in the history, e.g.
>
> -- Executing query [Query 1]:
> SELECT version();
> Total query runtime: 16 msec
> 1 row retrieved.
>
> -- Executing query [Query 2]:
> SELECT * FROM pg_class
> Total query runtime: 53 msec
> 311 rows retrieved.
>
> -- Executing query [foo.sql]:
> SELECT * from pg_attribute
> Total query runtime: 245 msec
> 2399 rows retrieved.
>
> What do you think?
>
>
>> Regards.
>>
>> On Fri, Feb 5, 2016 at 7:46 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> On Wed, Feb 3, 2016 at 3:07 AM, Sergey Busel <sbusel(at)gmail(dot)com> wrote:
>>> > - Removed unused/commented code.
>>> > - Tab names now reflect the file name, if such is associated with a
>>> tab.
>>> > - Removed the "Close Tab" menu item. Added X button to the active tab.
>>> > - To tell the user which tab results are related to and to avoid
>>> messing
>>> > with perspective, the name of the related tab is now displayed as "Data
>>> > Output [Query 1]" in the output pane. If the tab is named after a
>>> file, file
>>> > name will display in the square brackets. If the file name is longer
>>> then 15
>>> > chars, it will be truncated to 15 chars.
>>> >
>>> > Let me know any other suggestions you may have.
>>>
>>> Thanks - this seems to be working nicely for me. It would be good if
>>> the query name could be displayed in the title bar of the output pane
>>> rather than on the results tab (because it really does apply to all
>>> tabs), but I don't see any sensible way to do that given the weird way
>>> that wxAUI stores it's perspectives.
>>>
>>> Ashesh, any ideas?
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>