Re: Crash after changing pgAgent Jobs

Hi Günther,

I had a look at the issue and the case is reproducible to me also, but this
happens only if do the following steps:

1. Open options dialog and in the UI Miscellaneous tab select 'Refresh
object and children on click' for Refresh on click option.
2. Open the properties dialog of a job.
3. Select some other node on the object browser.
4. Then select again the job node.
5. The Message box with message "There are properties dialogues open for
one or more objects that would be refreshed. Please close the properties
dialogues and try again.".

From the understanding that I got after reading your mail what happens in
your case is as follows:

1. Open options dialog and in the UI Miscellaneous tab select 'Refresh
object and children on click' for Refresh on click option.
2. Open the properties dialog of a job.
3. Uncheck the 'Enabled' the checkbox in the dialog.
4. Click OK button and the message box pop-up.

Well the same message box was not reproducible to me based on these steps.

If the first set of steps are true then according to the code
the behavior is expected, because when we refresh a node or it's children,
we re-construct their objects and the previous objects are deleted. If we
do not keep this check then this might lead to crashes and segmentation
faults as the dialogs tend to use the pre-constructed objects.

I am not sure if the text of the message box shown in this case is
appropriate or not in context to the situation in which it gets pop-ed up.

Dave, Thoughts/Comments?

Thanks,

On Fri, Nov 9, 2012 at 1:35 PM, <UNTERRAINER(dot)Guenther(at)leitwind(dot)com> wrote:

> Hi Dhiraj, to this issue:
>
>
> > One more behavior to the refresh-option below:
> >
> > If I just try to deactivate a Job on confirming I get the error-message:
> > Cannot refresh browser
> > There are properties dialogues open for one or more objects that would
> > be refreshed. Please close the properties dialogues and try again.
> >
> > But I don't have any other dialogues open.
> >
>
> This happens if the refresh option in Options->UI Misellaneous->Refresh on
> click is set to
> Refresh object and children on click
>
> Sorry for my inaccurateness!
> Günther
>
>
> ___________________________________
> Günther Unterrainer
> Wind Generators Projects & Service IT
>
> LEITWIND AG - SpA
> Brennerstraße 34 - Via Brennero, 34
> I-39049 Sterzing - Vipiteno
> Tel. +39 0472 722 443
>
> http://www.leitwind.com
>
> Please consider the environment before printing this email
>
> Dhiraj Chawla <dhiraj(dot)chawla(at)enterprisedb(dot)com> wrote on 08.11.2012
> 14:21:16:
>
> > Dhiraj Chawla <dhiraj(dot)chawla(at)enterprisedb(dot)com>
> > 08.11.2012 14:21
> >
> > To
> >
> > UNTERRAINER(dot)Guenther(at)leitwind(dot)com, Dave Page <dpage(at)pgadmin(dot)org>
> >
> > cc
> >
> > pgAdmin Support <pgadmin-support(at)postgresql(dot)org>
> >
> > Subject
> >
> > Re: [pgadmin-support] Crash after changing pgAgent Jobs
>
> >
> > Hi Guenther,
>
> > On Tue, Nov 6, 2012 at 5:12 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> > Dhiraj, can you look into this please?
> >
> > Thanks.
> >
> > On Mon, Nov 5, 2012 at 9:24 AM, <UNTERRAINER(dot)Guenther(at)leitwind(dot)com>
> wrote:
> > > One more behavior to the refresh-option below:
> > >
> > > If I just try to deactivate a Job on confirming I get the
> error-message:
> > > Cannot refresh browser
> > > There are properties dialogues open for one or more objects that would
> > > be refreshed. Please close the properties dialogues and try again.
> > >
> > > But I don't have any other dialogues open.
> > >
> >
> > I am not able to reproduce this case at my end with the steps as
> > given by you. Can you please provide me more information and
> > specific steps that you did to reproduce this error?
> >
> >
> > > Regards
> > > Günther
> > >
> > >
> > >
> > >
> > >
> > > Hi all,
> > >
> > > Since I am using PgAdmin v.1.16.0 on Windows 7 64 bit when I change
> anything
> > > on a pgAgent job
> > > pgAgent chrashes.
> > > This happens only if I the new tree refresh option is turned on in
> > > Options->UI Miscellaneous->Refresh on click->Refresh object on click
> > > When I turn this option off it works fine.
> > >
> >
> > This crash was reproducible to me and am looking into it.
> >
> > > Thank you!
> > >
> > > Günther
> > >
> > >
> --------------------------------------------------------------------------
> > > This email and any files transmitted with it are confidential and
> intended
> > > solely for the use of the individual or entity to whom they are
> addressed.
> > > If you have received this email in error please notify the system
> manager.
> > >
> > > Think GREEN before you print!
> > > Before you print, please consider if it is necessary.
> > > Printing uses electricity, ink and paper.
> > >
> --------------------------------------------------------------------------
> >
> >
>
> > --
> > Dave Page
> > Blog: http://pgsnake.blogspot.com
> > Twitter: @pgsnake
> >
> > EnterpriseDB UK: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
>
> >
> > --
> > regards,
> >
> > Dhiraj Chawla
> > Software Engineer
> > EnterpriseDB Corporation
> > The Enterprise PostgreSQL Company
> >
> > Phone: +91-20-30589522
> --------------------------------------------------------------------------
> This email and any files transmitted with it are confidential and intended
> solely for the use of the individual or entity to whom they are addressed.
> If you have received this email in error please notify the system manager.
>
> Think GREEN before you print!
> Before you print, please consider if it is necessary.
> Printing uses electricity, ink and paper.
> --------------------------------------------------------------------------
>

--
regards,

*Dhiraj Chawla*
Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91-20-30589522