| From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
|---|---|
| To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c) |
| Date: | 2021-08-17 13:22:18 |
| Message-ID: | CAJcOf-fYrDgsoK1-5PfpKaoeOcQUO_c_KMtOyn32HUZsU-vkYA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 17, 2021 at 9:13 PM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
>
> If that's conditions happen, all *result.index* touches are garbage.
>
The patch looks valid to me, as the "index" member is not set in the
"btp == NULL" case, and so has a junk value in the caller, and it's
being used to index an array,
BUT - isn't it also necessary to set the "split_pages" member to 0,
because it also is not currently being set, and so too will have a
junk value in this case (and it's possible for it to be referenced by
the caller in this case).
The "btp == NULL" case is not hit by any existing test cases, and does
seem to be a rare case.
Regards,
Greg Nancarrow
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-08-17 13:25:30 | Re: Added schema level support for publication. |
| Previous Message | Andres Freund | 2021-08-17 13:17:51 | Re: The Free Space Map: Problems and Opportunities |