Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c)

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c)
Date: 2021-08-17 11:13:35
Message-ID: CAEudQArroryU3bAnqSztZhGDovrESdhKPDquhBq23x-Fv=khMg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em ter., 17 de ago. de 2021 às 05:04, Michael Paquier <michael(at)paquier(dot)xyz>
escreveu:

> On Fri, Jul 02, 2021 at 06:22:56PM -0300, Ranier Vilela wrote:
> > Em qui., 1 de jul. de 2021 às 17:20, Mahendra Singh Thalor <
> > mahi6run(at)gmail(dot)com> escreveu:
> >> Please can we try to hit this rare condition by any test case. If you
> have
> >> any test cases, please share.
>
> Yeah, this needs to be proved.

Due to the absolute lack of reports, I believe that this particular case
never happened.

Are you sure that this change is
> actually right?

Yes, have.

The bottom of FreePageManagerPutInternal() has
> assumptions that a page may not be found during a btree search, with
> an index value used.
>
Assert assumptions are for Debug.
If that's conditions happen, all *result.index* touches are garbage.

regards,
Ranier Vilela

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2021-08-17 11:22:33 Re: ALTER TYPE vs extension membership (was Re: BUG #17144: Upgrade from v13 to v14 with the cube extension failed)
Previous Message tanghy.fnst@fujitsu.com 2021-08-17 11:08:59 RE: [PATCH]Remove obsolete macro CHECKFLOATVAL in btree_gist