Re: [PATCH] Optimize SP-GiST text leaf comparisons with memcmp

From: James Hunter <james(dot)hunter(dot)pg(at)gmail(dot)com>
To: ahmedashour <a8087027(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Optimize SP-GiST text leaf comparisons with memcmp
Date: 2025-02-26 18:38:21
Message-ID: CAJVSvF4YLOMWUVMD7P_LgZQQvZK7MyPLtD-K3aJyCCOPESjjPQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 12, 2025 at 5:14 PM ahmedashour <a8087027(at)gmail(dot)com> wrote:
>
> Thank you for your feedback and review! I have addressed the comments and updated the patch accordingly. Below are the details of the changes:
>
> Please review the updated patch and let me know if there are any further issues or suggestions for improvement.

The patch has a lot of whitespace diffs -- were these intentional? If
you run "pgindent" on your change, before creating a patch, that tool
will normalize the whitespace to PostgreSQL coding standard.

For example, attached is your patch, but with "pgindent" run on it
first. So the patch / diff is much smaller now.

James

Attachment Content-Type Size
0001-PATCH-Optimize-SP-GiST-text-leaf-comparisons-with-me.patch application/octet-stream 3.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2025-02-26 18:44:33 Re: Statistics Import and Export
Previous Message Melanie Plageman 2025-02-26 18:37:40 Re: Log connection establishment timings