Re: master fails to build on Windows

From: John Naylor <jcnaylor(at)gmail(dot)com>
To: Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: master fails to build on Windows
Date: 2018-05-18 11:49:15
Message-ID: CAJVSVGU0B-r4EhdNqy3GL03e=rhBG8wAweUAzYKwkSX1J-x8Fw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 5/18/18, Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com> wrote:
> Hi
>
> I was building the sources I got from https://www.postgresql.org/
> ftp/snapshot/dev/ on Windows x64 and got the whole bunch of errors
> like "*Cannot
> open include file: 'catalog/pg_type_d.h"* , *"Cannot open include file:
> 'catalog/pg_tablespace_d.h'" . *I've attached the log.

I'm thinking the include/catalog/pg_*_d.h headers got dist-cleaned
when creating the snapshot, and the build script doesn't know to copy
them over. If you're able to test, does the attached patch fix the
issue? (This may not be the right permanent fix, but hopefully it will
confirm my suspicion)

-John Naylor

Attachment Content-Type Size
msvc-copy-bki-to-include-dir.patch text/x-patch 1.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2018-05-18 12:54:47 Re: pg_control read error message
Previous Message Magnus Hagander 2018-05-18 11:32:41 pg_control read error message