| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Support Int64 GUCs |
| Date: | 2024-09-12 11:34:40 |
| Message-ID: | CAJ7c6TPWJJpzgtXuEQ6ARrSYUeHnrX=VTo_n0UghcrsC20UgTg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Pavel,
> I think the direction is good and delivering 64-bit GUCs is very much worth committing.
> The patch itself looks good, but we could need to add locks against concurrently modifying 64-bit values, which could be non-atomic on older architectures.
Thanks for the feedback.
> I think 12345678912345 is good enough. Underscore dividers make reading little bit easier but look weird overall. I can't remember other places where we output long numbers with dividers.
We already support this in SQL:
psql (18devel)
=# SELECT 123_456;
?column?
----------
123456
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2024-09-12 12:07:20 | Re: Avoid dead code (contrib/pg_visibility/pg_visibility.c) |
| Previous Message | Pavel Borisov | 2024-09-12 11:29:14 | Re: [PATCH] Support Int64 GUCs |