| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Avoid dead code (contrib/pg_visibility/pg_visibility.c) |
| Date: | 2024-09-12 12:07:20 |
| Message-ID: | CAEudQAo6BumTvfyxsx_gt2jyPEgfkspJ=jgyiS7-7pkuEhmqdg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em qui., 12 de set. de 2024 às 02:18, Michael Paquier <michael(at)paquier(dot)xyz>
escreveu:
> On Wed, Sep 04, 2024 at 01:50:24PM -0300, Ranier Vilela wrote:
> > I think that commit c582b75
> > <
> https://github.com/postgres/postgres/commit/c582b75851c2d096ce050d753494505a957cee75
> >,
> > left an oversight.
> >
> > The report is:
> > CID 1559993: (#1 of 1): Logically dead code (DEADCODE)
> >
> > Trivial patch attached.
>
> I am not sure to understand what you mean here and if this is still
> relevant as of Noah's latest commit in 65c310b310a6.
>
Sorry Michael, but this patch became irrelevant after ddfc556
<http://ddfc556a644404a8942e77651f75f09aa5188782>
Note the omission to connect the dots, from the commit.
best regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Borisov | 2024-09-12 12:09:08 | Re: POC: make mxidoff 64 bits |
| Previous Message | Aleksander Alekseev | 2024-09-12 11:34:40 | Re: [PATCH] Support Int64 GUCs |