| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Junwang Zhao <zhjwpku(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: [PATCH v1] PQputCopyEnd never returns 0, fix the inaccurate comment |
| Date: | 2023-08-30 10:28:53 |
| Message-ID: | CAJ7c6TO=8oHfVhevUKEYJOpER=x+NhDofa4oOsxUYAouBwCwzg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> > On Mon, Aug 28, 2023 at 09:46:07PM +0800, Junwang Zhao wrote:
> > > Yeah, it makes sense to me, or maybe just `PQputCopyEnd(...) == -1`,
> > > let's wait for some other opinions.
> >
> > One can argue that PQputCopyEnd() returning 0 could be possible in an
> > older version of libpq these callers are linking to, but this has
> > never existed from what I can see (just checked down to 8.2 now).
> > Anyway, changing these callers may create some backpatching conflicts,
> > so I'd let them as they are, and just fix the comment.
>
> sure, thanks for the explanation.
The patch was applied in 8bf7db02 [1] and I assume it's safe to close
the corresponding CF entry [2].
Thanks, everyone.
[1]: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=8bf7db0285dfbc4b505c8be4c34ab7386eb6297f
[2]: https://commitfest.postgresql.org/44/4521/
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2023-08-30 10:40:10 | Re: Avoid a possible overflow (src/backend/utils/sort/logtape.c) |
| Previous Message | Peter J. Holzer | 2023-08-30 10:00:30 | Re: Restoring default privileges on objects |