| From: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH v1] PQputCopyEnd never returns 0, fix the inaccurate comment |
| Date: | 2023-08-29 09:45:30 |
| Message-ID: | CAEG8a3L97aFoMWCxyNirY4F67=13G9DSGfaW6xxinv4WckXeHw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 29, 2023 at 6:40 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Aug 28, 2023 at 09:46:07PM +0800, Junwang Zhao wrote:
> > Yeah, it makes sense to me, or maybe just `PQputCopyEnd(...) == -1`,
> > let's wait for some other opinions.
>
> One can argue that PQputCopyEnd() returning 0 could be possible in an
> older version of libpq these callers are linking to, but this has
> never existed from what I can see (just checked down to 8.2 now).
> Anyway, changing these callers may create some backpatching conflicts,
> so I'd let them as they are, and just fix the comment.
sure, thanks for the explanation.
> --
> Michael
--
Regards
Junwang Zhao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2023-08-29 10:02:48 | Re: Prevent psql \watch from running queries that return no rows |
| Previous Message | Zhijie Hou (Fujitsu) | 2023-08-29 09:44:54 | RE: logical_replication_mode |