Re: Add json_typeof() and json_is_*() functions.

From: Merlin Moncure <mmoncure(at)gmail(dot)com>
To: Andrew Tipton <andrew(at)kiwidrew(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add json_typeof() and json_is_*() functions.
Date: 2013-08-02 12:43:21
Message-ID: CAHyXU0wf4fPoZVKvSsMGsUQVP0Psu9FZqVYWT3tbtK2uq0w9Zw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 2, 2013 at 7:22 AM, Andrew Tipton <andrew(at)kiwidrew(dot)com> wrote:
> On Fri, Aug 2, 2013 at 8:12 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>
>> +1, but I'm wondering why we need anything more than just
>> json_typeof(). Doesn't that pretty much cover it?
>
>
> I agree with Merlin that json_is_object() is superfluous, since it can just
> be replaced with json_typeof() = 'object'. Likewise for json_is_array().
> But without json_is_scalar(), the choice is one of these two forms:
> json_typeof() NOT IN ('object', 'array')
> json_typeof() IN ('string', 'number', 'boolean', 'null')
>
> And it protects the user against forgetting about, say, the 'null' typeof()
> when constructing their check expression.

right: I was thinking also that if/when json were ever to get new
types, you'd appreciate that function.

merlin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-08-02 12:45:56 Re: Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])
Previous Message Stephen Frost 2013-08-02 12:41:09 Re: Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])